/scripts/gc.sh does no end

[eleaner]

Hi,
I assume it might be a problem with the script itself, but maybe someone saw it before?
so I go to the container and I run the script
it executes perfectly bu tthen it never ends with such problem

(...)
2023-03-15 12:54:28 gc-core.c(606): === GC is finished ===
seafserv-gc run done

Done.
Seafile CE: Offline garbage collection completed. Starting Seafile.

Starting seafile server, please wait ...
** Message: 12:54:31.807: seafile-controller.c(621): No seafevents.

Seafile server started

Done.
Waiting for SeaRPC socket...
2023/03/15 12:54:34 socat[12985] W ioctl(5, IOCTL_VM_SOCKETS_GET_LOCAL_CID, ...): Inappropriate ioctl for device

[Larrikinau]

I have the same issue

[ggogel]

Hi, can you post the complete log, please?

How exactly did you execute the script?

Please try using docker exec, as described in the wiki.

docker exec -it seafile-server /scripts/gc.sh

[ggogel]

I was able to reproduce and fix the issue.

Relevant commit: d085480

I've never noticed it because I run the script through Cron and the script not terminating was never an issue there.

[Larrikinau]

Thanks. Do you need to update the docker-compose file to reflect the new seafile version number?

[ggogel]

Depends on what tag you are using. Some tags are re-used, some are specific. The latest seafile-server image is tagged with latest, 10.0.1 and 10.0.1_002.

[Larrikinau]

I tag it with how you update docker-compose.yml so I currently have 10.0.1. I tried 10.0.1_002 but it bugged out immediately when trying to download the new docker. From: Gerrit Gogel ***@***.***> ***@***.***> Reply: ggogel/seafile-containerized ***@***.***> ***@***.***> Date: 18 April 2023 at 4:32:17 pm To: ggogel/seafile-containerized ***@***.***> ***@***.***> Cc: Larrikinau ***@***.***> ***@***.***>, Comment ***@***.***> ***@***.***> Subject: Re: [ggogel/seafile-containerized] /scripts/gc.sh does no end (Issue #90) Depends on what tag you are using. Some tags are re-used, some are specific. The latest seafile-server image is tagged with latest, 9.0.1 and 9.0.1_002. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATNOKMNWKMPJSAKTEAVWRTDXBYYPDANCNFSM6AAAAAAV32FQKI> . You are receiving this because you commented.Message ID: ***@***.***>

[ggogel]

What was the error message?

[Larrikinau]

Sorry - I know how annoying it is for devs to get a msg like that. I was in a rush. The error msg is: Pulling seahub-media (ggogel/seahub-media:10.0.1_002)... ERROR: manifest for ggogel/seahub-media:10.0.1_002 not found: manifest unknown: manifest unknown From: Gerrit Gogel ***@***.***> ***@***.***> Reply: ggogel/seafile-containerized ***@***.***> ***@***.***> Date: 18 April 2023 at 5:13:59 pm To: ggogel/seafile-containerized ***@***.***> ***@***.***> Cc: Larrikinau ***@***.***> ***@***.***>, Comment ***@***.***> ***@***.***> Subject: Re: [ggogel/seafile-containerized] /scripts/gc.sh does no end (Issue #90) What was the error message? — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATNOKMKYHGIGUIZLGCJXKZLXBY5LPANCNFSM6AAAAAAV32FQKI> . You are receiving this because you commented.Message ID: ***@***.***>

[Larrikinau]

BTW, the other thing is that I manually edited the gc.sh file as per your update (ie adding the &).

It ran this time but still produced this error message as per above

2023/03/15 12:54:34 socat[12985] W ioctl(5, IOCTL_VM_SOCKETS_GET_LOCAL_CID, ...): Inappropriate ioctl for device

Everything still seemed to work but I don't know why that error message. Out of an abundance of caution, I stopped seafile, and restarted it.

[ggogel]

You changed the tag of the wrong image. seafile-server has a new version, seafile-media doesn't.

2023/03/15 12:54:34 socat[12985] W ioctl(5, IOCTL_VM_SOCKETS_GET_LOCAL_CID, ...): Inappropriate ioctl for device

You can ignore this message. See https://stackoverflow.com/questions/1605195/inappropriate-ioctl-for-device

[Larrikinau]

I have actually created a variable file with that allows me to peg the seafile-server version. As it turns out, I use that same variable to cover seahub and seahub-media as until today, they all followed the same version number, so was easy programming on my part to make it a variable that changed all three at the same time. I’d rather keep to that because I presume that the next seafile upgrade, the numbers will all align again, and its neater code on my side to maintain the various dockers. As I say, this is the first time I’ve ever seen you depart from that numbering schema, but I know you’ll revert back to it with the next release, so all good. From: Gerrit Gogel ***@***.***> ***@***.***> Reply: ggogel/seafile-containerized ***@***.***> ***@***.***> Date: 18 April 2023 at 8:41:42 pm To: ggogel/seafile-containerized ***@***.***> ***@***.***> Cc: Larrikinau ***@***.***> ***@***.***>, Comment ***@***.***> ***@***.***> Subject: Re: [ggogel/seafile-containerized] /scripts/gc.sh does no end (Issue #90) You changed the tag of the wrong image. seafile-server has a new version, seafile-media doesn't. 2023/03/15 12:54:34 socat[12985] W ioctl(5, IOCTL_VM_SOCKETS_GET_LOCAL_CID, ...): Inappropriate ioctl for device You can ignore this message. See https://stackoverflow.com/questions/1605195/inappropriate-ioctl-for-device — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATNOKMJ2CCFAWQQS3256RZLXBZVWNANCNFSM6AAAAAAV32FQKI> . You are receiving this because you commented.Message ID: ***@***.***>

[ggogel]

I'm not departing from the versioning schema. I'm using it since the beginning. The first part (10.0.1) is the Seafile version. The second part (001) is the build number of the specific component. If you want to use the same tag on all components you can just use the tag 10.0.1, which always refers to the latest build under this Seafile version.

Just make sure you actually pull the image version if using tags that are getting re-used.

[Larrikinau]

OK, I’ve done that but it doesn’t pull down your fix with the (002). It just starts up my dockers as normal as I’ve kept to your docker-compose.yaml of 10.0.1 - I don’t assign a build number and never have. I literally just follow your versioning schema as you update it on the docker-compose file, and then I update my variable file accordingly. Am I missing something? Also, I should say thanks again for all the work you put into this. I love your work and love the way you have set this up. You really understand security and its awesome to be able to piggy back off your hard work. From: Gerrit Gogel ***@***.***> ***@***.***> Reply: ggogel/seafile-containerized ***@***.***> ***@***.***> Date: 18 April 2023 at 8:53:10 pm To: ggogel/seafile-containerized ***@***.***> ***@***.***> Cc: Larrikinau ***@***.***> ***@***.***>, Comment ***@***.***> ***@***.***> Subject: Re: [ggogel/seafile-containerized] /scripts/gc.sh does no end (Issue #90) I'm not departing from the versioning schema. I'm using it since the beginning. The first part (10.0.1) is the Seafile version. The second part ( 001) is the build number of the specific component. If you want to use the same tag on all components you can just use the tag 10.0.1, which always refers to the latest build under this Seafile version. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATNOKMKICXJOV6UAIU5X56DXBZXBLANCNFSM6AAAAAAV32FQKI> . You are receiving this because you commented.Message ID: ***@***.***>

[ggogel]

Thank you, it makes my day to hear that.

Try to execute docker-compose pull. This should check if any new versions under the given image tags are available and pull them. Then execute the docker-compose up command again.

[Larrikinau]

Boom. you are the best. That worked and now gc.sh works. now I can add it to cron. out of interest, how often do you run it? I have 90 day retention for deleted files set for my libraries. From: Gerrit Gogel ***@***.***> ***@***.***> Reply: ggogel/seafile-containerized ***@***.***> ***@***.***> Date: 18 April 2023 at 9:03:31 pm To: ggogel/seafile-containerized ***@***.***> ***@***.***> Cc: Larrikinau ***@***.***> ***@***.***>, Comment ***@***.***> ***@***.***> Subject: Re: [ggogel/seafile-containerized] /scripts/gc.sh does no end (Issue #90) Thank you, it makes my day to hear that. Try to execute docker-compose pull. This should check if any new versions under the given image tags are available and pull them. Then execute the docker-compose up command again. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATNOKMN5HANZGS2XX5V3ALLXBZYIHANCNFSM6AAAAAAV32FQKI> . You are receiving this because you commented.Message ID: ***@***.***>

[ggogel]

Great 👍

I run it every Sunday. It shouldn't affect your retention. It will only remove chunks of files that are actually deleted, meaning not being held in deleted files anymore.