Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing data dir via env #65

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Support passing data dir via env #65

merged 3 commits into from
Feb 29, 2024

Conversation

PeronGH
Copy link
Contributor

@PeronGH PeronGH commented Feb 29, 2024 •
edited

This PR allows the user to customize the path of data dir via the OTERM_DATA_DIR env.

@ggozad
Copy link
Owner

ggozad commented Feb 29, 2024

Thank you!
Could you also add yourself in the CHANGES.txt for 0.2.4 and a mention of the setting in the README?

@PeronGH
Copy link
Contributor Author

PeronGH commented Feb 29, 2024

Sure, I've modified CHANGES.txt and README.

ggozad
ggozad requested changes Feb 29, 2024
View reviewed changes
Copy link
Owner

@ggozad ggozad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can just address that little change, LGTM

oterm/utils.py Outdated Show resolved Hide resolved
@ggozad ggozad merged commit 68f45b8 into ggozad:main Feb 29, 2024
@ggozad
Copy link
Owner

ggozad commented Feb 29, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggozad ggozad ggozad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeronGH @ggozad