Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golden Rectangle GDL/visualization mismatch #29

Closed
AlexLandau opened this issue Mar 18, 2015 · 3 comments
Closed

Golden Rectangle GDL/visualization mismatch #29

AlexLandau opened this issue Mar 18, 2015 · 3 comments

Comments

@AlexLandau
Copy link
Member

The Golden Rectangle game description has eight rows (0 through 7), but the visualization only shows seven (0 through 6). This should be resolved one way or the other.

Games usually don't last long enough for the error to be apparent.
@AlexLandau
Copy link
Member Author

Sample match where this happened: http://www.ggp.org/view/tiltyard/matches/0fb1a5f765509d6f93c006e4978771d6ebbb5ebf/

@samschreiber
Copy link
Member

We should update the visualization. That way, we won't invalidate the previous matches (or need to increment the version).

@AlexLandau
Copy link
Member Author

Fixed by #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samschreiber @AlexLandau