Add directlabels #133
Merged
Add directlabels #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The readme mentions 'url or list of urls' so I suppose that is possible (comma-seperated?), but I haven't seen an example yet so wanted to confirm before I break the pattern. |
|
Thanks Anirban |
Anytime! |
Sorry, I don't know. If you want to try, you can add them. In case it won't work, I'll fix it. |
Done, please check! |
|
Thanks! |
|
It seems the second one is just ignored. |
|
Thank you too!
I see, might as well update that on the readme? (like to just use one url) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added directlabels on behalf of @tdhock as per the second objective here (an open-source project!)
Thumbnail taken from tdhock/directlabels#42 (comment)
@yutannihilation Can we add multiple links for the 'examples' field?
I went for https://tdhock.github.io/directlabels/docs/index.html which is an example database with links to examples for specific methods, but then there is also a page for several advanced examples: https://tdhock.github.io/directlabels/examples.html
Ideally, it would be nice to have both, but its fine if only one is accepted.