Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abootimg: Improve compatability with no-initrd abootimg configs #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnstultz-work
Copy link

With newer AOSP devices, system can be used as rootfs, resulting
in no initrd being used in the bootimg.

Without this patch, 'abootimg -x' on such an image would result
with:
/home/jstultz/noinitrd-boot.img: ramdisk size is null
/home/jstultz/noinitrd-boot.img: not a valid Android Boot Image.

This patch just avoids failing out when we see a null ramdisk size.

Signed-off-by: John Stultz john.stultz@linaro.org

With newer AOSP devices, system can be used as rootfs, resulting
in no initrd being used in the bootimg.

Without this patch, 'abootimg -x' on such an image  would result
with:
/home/jstultz/noinitrd-boot.img: ramdisk size is null
/home/jstultz/noinitrd-boot.img: not a valid Android Boot Image.

This patch just avoids failing out when we see a null ramdisk size.

Signed-off-by: John Stultz <john.stultz@linaro.org>
@temoto
Copy link

temoto commented May 16, 2019

This patch is required to work with stock OrangePi images. Please merge.

@lag-linaro
Copy link

lag-linaro commented Oct 18, 2019

Could someone merge this PR please?

It fixes a severe issue when working with current Android images.

LGTM - +1

@phhusson
Copy link

"someone".
You do realize this is a one-people project they do (well did it looks like) on their free time?
And there has been no commit since 2012 just saying "please merge" will probably not cut it.

I understand your corporate want this, I think you can feel free to fork it and maintain it.

Also "current Android images" doesn't need this because of Android Q's first-stage init.

If I'm not mistaken, this is required exclusively on Android Pie devices running system-as-root without A/B slots.

@lag-linaro
Copy link

"someone".
You do realize this is a one-people project they do (well did it looks like) on their free time?

Yes.

And there has been no commit since 2012 just saying "please merge" will probably not cut it.

I see that. It doesn't mean they won't take a few minutes out of their time to press "merge".

I understand your corporate want this, I think you can feel free to fork it and maintain it.

This doesn't have anything to do with "my corporate".

Also "current Android images" doesn't need this because of Android Q's first-stage init.

If I'm not mistaken, this is required exclusively on Android Pie devices running system-as-root without A/B slots.

Okay, good to know. It's still required for certain use-cases though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants