Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin build failures #1405

Open
me-and opened this issue Aug 30, 2020 · 0 comments · May be fixed by #1406
Open

Cygwin build failures #1405

me-and opened this issue Aug 30, 2020 · 0 comments · May be fixed by #1406

Comments

@me-and
Copy link
Contributor

me-and commented Aug 30, 2020

Currently, Cygwin builds are failing; it looks like the relevant #defines in Cygwin have changed at some point. Specifically, when trying to compile, I get the following error:

  CC       src/main.o
In file included from /usr/include/sys/_pthreadtypes.h:12,
                 from /usr/include/sys/types.h:223,
                 from /usr/include/stdio.h:61,
                 from src/main.c:4:
src/main.c: In function ‘main’:
src/main.c:162:27: error: ‘cpu_set’ undeclared (first use in this function); did you mean ‘cpu_set_t’?
  162 |                 CPU_ZERO(&cpu_set);
      |                           ^~~~~~~
src/main.c:162:27: note: each undeclared identifier is reported only once for each function it appears in
make: *** [Makefile:507: src/main.o] Error 1

I have a fix, which I'm going to put into a PR now…

@me-and me-and linked a pull request Aug 30, 2020 that will close this issue
me-and pushed a commit to cygporter/the_silver_searcher that referenced this issue Aug 31, 2020
There's an error in the #define tests that means Cygwin isn't detected
as a Linux system, so a critical variable doesn't get defined.

This works around the upstream ggreer/the_silver_searcher#1405; a
similar patch is in the upstream pull request queue as
ggreer/the_silver_searcher#1406.
me-and added a commit to cygporter/the_silver_searcher that referenced this issue Aug 31, 2020
There's an error in the #define tests that means Cygwin isn't detected
as a Linux system, so a critical variable doesn't get defined.

This works around the upstream ggreer/the_silver_searcher#1405; a
similar patch is in the upstream pull request queue as
ggreer/the_silver_searcher#1406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant