-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The silver searcher to rust #1418
Open
PhilSmith31
wants to merge
21
commits into
ggreer:master
Choose a base branch
from
IncrementalTransitionOfCCodeIntoRust:the_silver_searcher_to_rust
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8ccabd8
initial rust setup
PhilSmith31 3aacd5d
filename_filter in rust
PhilSmith31 0bd95ac
expose path_ignore_search in header for rust to work
PhilSmith31 a70ee05
path_ignore_search to rust done
PhilSmith31 8022b44
eliminated a lot of unsafe, by creating a placeholder function to log…
PhilSmith31 08c4451
remove unnecessary header
PhilSmith31 a4c13ab
fix hidden_option.t and adjust returns
PhilSmith31 557d151
fixed ignore_extensions.t
PhilSmith31 ebe6bd9
fixed ignore_slash_in_subdir.t
PhilSmith31 df74fe0
fixed ignore_subdirs.t
PhilSmith31 8720cce
removed private test - all global tests are passing now!
PhilSmith31 ac93ccd
some formatting
PhilSmith31 d512318
some smallish optimizations
PhilSmith31 eb8b8fc
some more smallish stuff
PhilSmith31 35f6f4b
remove unnecessary instructions from build.rs
PhilSmith31 c500795
some more smallish optimizations
PhilSmith31 9de3448
return String from helper method
PhilSmith31 974f6f8
import correct function now
PhilSmith31 446b9a0
in fl_c_array_to_str actually all own method
PhilSmith31 878abbe
explanation for pull request
PhilSmith31 27dc634
fix formatting
PhilSmith31 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#!/bin/bash | ||
|
||
make clean-local-rust && make clean && make distclean |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pretty cool to hear about!