Fix the test for clang-format
#660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This consists of two changes: 1. The syntax in `configure.ac` was incorrect; the effect was that the build script always thought that the `clang-format` command was available, even if `$CLANG_FORMAT` was equal to `no`. 2. `format.sh` did not notice if `$CLANG_FORMAT` was not an actual command; in this case it would actually report that the code was formatted correctly and exit with a 0 status code. (This happened because the result of `clang-format` was being piped through `grep` and so the failure code from the invalid `clang-format` command was silently ignored.)
|
Thanks so much for finding and fixing these bugs. |
ggreer
added a commit
that referenced
this pull request
Apr 22, 2015
Fix the test for `clang-format`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists of two changes:
configure.acwas incorrect; the effect was that the build script always thought that theclang-formatcommand was available, even if$CLANG_FORMATwas equal tono.format.shdid not notice if$CLANG_FORMATwas not an actual command; in this case it would actually report that the code was formatted correctly and exit with a 0 status code. (This happened because the result ofclang-formatwas being piped throughgrepand so the failure code from the invalidclang-formatcommand was silently ignored.)