Prefer .ignore to .agignore. #974
Conversation
…ted. Add test case to ensure ag -U works.
… make sure the functionality works.
…re will still work for the forseeable future, but .ignore is preferred.
But don't actually remove support for .rgignore until the next semver bump. Note that this puts us in line with the silver searcher: ggreer/the_silver_searcher#974 Fixes #40
But don't actually remove support for .rgignore until the next semver bump. Note that this puts us in line with the silver searcher: ggreer/the_silver_searcher#974 Fixes BurntSushi#40
| @@ -195,13 +195,13 @@ run `ag --list-file-types`. | |||
| ## IGNORING FILES | |||
|
|
|||
| By default, ag will ignore files whose names match patterns in .gitignore, | |||
| .hgignore, or .agignore. These files can be anywhere in the directories being | |||
| .hgignore, or .ignore. These files can be anywhere in the directories being | |||
| searched. Ag also ignores files matched by the svn:ignore property if `svn | |||
| --version` is 1.6 or older. Finally, ag looks in $HOME/.agignore for ignore | |||
There was a problem hiding this comment.
Finally, ag looks in $HOME/.agignore
Shouldn't it now say $HOME/.ignore?
There was a problem hiding this comment.
Seems like ag 1.0.3 doesn't take ~/.ignore into account at all (still ignoring patterns from ~/.agignore).
|
Good work on agreeing to commonly use I have a minor quibble... I imagine some poor soul Also relevant for BurntSushi/ripgrep#41 |
|
In case anyone needs clarification:
|
Searching on the ref tests would find matches in the terminal recording files and completely screw up the screen state.
|
It would be great if ag could search for it in |
Ag and ripgrep both respect .ignore. See ggreer/the_silver_searcher#974
Ag and ripgrep both respect .ignore. See ggreer/the_silver_searcher#974
This has been supported for five years. I don't know why I didn't realize that. [1]: ggreer/the_silver_searcher#974
Thanks to discussion on https://news.ycombinator.com/item?id=12564442, @BurntSushi and I agreed on a common file name for ignore patterns. He's made his PR for ripgrep. This is ag's counterpart.
To those who worry about change: Please don't! It will be a long time before .agignore is no longer obeyed, if ever.