forked from kubernetes-csi/external-snapshotter
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
bc0504a Merge pull request kubernetes-csi#140 from jsafrane/remove-unused-k8s-libs 5b1de1a go-get-kubernetes.sh: remove unused k8s libs 49b4269 Merge pull request kubernetes-csi#120 from pohly/add-kubernetes-release a1e1127 Merge pull request kubernetes-csi#139 from pohly/kind-for-kubernetes-latest 1c0fb09 prow.sh: use KinD main for latest Kubernetes 1d77cfc Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10 bff2fb7 prow.sh: KinD 0.10.0 95eac33 Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check 437e431 verify-go-version.sh: fix check after removal of travis.yml 1748b16 Merge pull request kubernetes-csi#136 from pohly/go-1.16 ec844ea remove travis.yml, Go 1.16 df76aba Merge pull request kubernetes-csi#134 from andyzhangx/add-build-arg e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3 7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation e0b02e7 README.md: document usage of --squash 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate 26e2ab1 fix: default boilerplate path 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag 3e811d6 prow.sh: fix "on-master" prow jobs 1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag 9f10459 prow.sh: support building Kubernetes for a specific version f7e7ee4 docs: steps for adding testing against new Kubernetes release fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220 fix: fix a bug of csi-sanity a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate ece0f50 check namespace for snapshot-controller dbd8967 verify-boilerplate.sh: fix path to script 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 git-subtree-dir: release-tools git-subtree-split: bc0504a
- Loading branch information
Grant Griffiths
committed
Apr 15, 2021
1 parent
4893f4a
commit 4683101
Showing
20 changed files
with
578 additions
and
86 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,23 @@ | ||
| #! /bin/bash -e | ||
|
|
||
| # Copyright 2021 The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # This is for testing csi-release-tools itself in Prow. All other | ||
| # repos use prow.sh for that, but as csi-release-tools isn't a normal | ||
| # repo with some Go code in it, it has a custom Prow test script. | ||
|
|
||
| ./verify-shellcheck.sh "$(pwd)" | ||
| ./verify-spelling.sh "$(pwd)" | ||
| ./verify-boilerplate.sh "$(pwd)" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright YEAR The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright YEAR The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright YEAR The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /* | ||
| Copyright YEAR The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,200 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright 2019 The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from __future__ import print_function | ||
|
|
||
| import argparse | ||
| import difflib | ||
| import glob | ||
| import os | ||
| import re | ||
| import sys | ||
| from datetime import date | ||
|
|
||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "filenames", | ||
| help="list of files to check, all files if unspecified", | ||
| nargs='*') | ||
|
|
||
| # Rootdir defaults to the directory **above** the repo-infra dir. | ||
| rootdir = os.path.dirname(__file__) + "./../../" | ||
| rootdir = os.path.abspath(rootdir) | ||
| parser.add_argument( | ||
| "--rootdir", default=rootdir, help="root directory to examine") | ||
|
|
||
| default_boilerplate_dir = os.path.abspath(os.path.dirname(__file__)) | ||
|
|
||
| parser.add_argument( | ||
| "--boilerplate-dir", default=default_boilerplate_dir) | ||
|
|
||
| parser.add_argument( | ||
| "-v", "--verbose", | ||
| help="give verbose output regarding why a file does not pass", | ||
| action="store_true") | ||
|
|
||
| args = parser.parse_args() | ||
|
|
||
| verbose_out = sys.stderr if args.verbose else open("/dev/null", "w") | ||
|
|
||
| def get_refs(): | ||
| refs = {} | ||
|
|
||
| for path in glob.glob(os.path.join(args.boilerplate_dir, "boilerplate.*.txt")): | ||
| extension = os.path.basename(path).split(".")[1] | ||
|
|
||
| ref_file = open(path, 'r') | ||
| ref = ref_file.read().splitlines() | ||
| ref_file.close() | ||
| refs[extension] = ref | ||
|
|
||
| return refs | ||
|
|
||
| def file_passes(filename, refs, regexs): | ||
| try: | ||
| f = open(filename, 'r') | ||
| except Exception as exc: | ||
| print("Unable to open %s: %s" % (filename, exc), file=verbose_out) | ||
| return False | ||
|
|
||
| data = f.read() | ||
| f.close() | ||
|
|
||
| basename = os.path.basename(filename) | ||
| extension = file_extension(filename) | ||
| if extension != "": | ||
| ref = refs[extension] | ||
| else: | ||
| ref = refs[basename] | ||
|
|
||
| # remove build tags from the top of Go files | ||
| if extension == "go": | ||
| p = regexs["go_build_constraints"] | ||
| (data, found) = p.subn("", data, 1) | ||
|
|
||
| # remove shebang from the top of shell files | ||
| if extension == "sh" or extension == "py": | ||
| p = regexs["shebang"] | ||
| (data, found) = p.subn("", data, 1) | ||
|
|
||
| data = data.splitlines() | ||
|
|
||
| # if our test file is smaller than the reference it surely fails! | ||
| if len(ref) > len(data): | ||
| print('File %s smaller than reference (%d < %d)' % | ||
| (filename, len(data), len(ref)), | ||
| file=verbose_out) | ||
| return False | ||
|
|
||
| # trim our file to the same number of lines as the reference file | ||
| data = data[:len(ref)] | ||
|
|
||
| p = regexs["year"] | ||
| for d in data: | ||
| if p.search(d): | ||
| print('File %s is missing the year' % filename, file=verbose_out) | ||
| return False | ||
|
|
||
| # Replace all occurrences of the regex "CURRENT_YEAR|...|2016|2015|2014" with "YEAR" | ||
| p = regexs["date"] | ||
| for i, d in enumerate(data): | ||
| (data[i], found) = p.subn('YEAR', d) | ||
| if found != 0: | ||
| break | ||
|
|
||
| # if we don't match the reference at this point, fail | ||
| if ref != data: | ||
| print("Header in %s does not match reference, diff:" % filename, file=verbose_out) | ||
| if args.verbose: | ||
| print(file=verbose_out) | ||
| for line in difflib.unified_diff(ref, data, 'reference', filename, lineterm=''): | ||
| print(line, file=verbose_out) | ||
| print(file=verbose_out) | ||
| return False | ||
|
|
||
| return True | ||
|
|
||
| def file_extension(filename): | ||
| return os.path.splitext(filename)[1].split(".")[-1].lower() | ||
|
|
||
| skipped_dirs = ['Godeps', 'third_party', '_gopath', '_output', '.git', | ||
| 'cluster/env.sh', 'vendor', 'test/e2e/generated/bindata.go', | ||
| 'repo-infra/verify/boilerplate/test', '.glide'] | ||
|
|
||
| def normalize_files(files): | ||
| newfiles = [] | ||
| for pathname in files: | ||
| if any(x in pathname for x in skipped_dirs): | ||
| continue | ||
| newfiles.append(pathname) | ||
| return newfiles | ||
|
|
||
| def get_files(extensions): | ||
| files = [] | ||
| if len(args.filenames) > 0: | ||
| files = args.filenames | ||
| else: | ||
| for root, dirs, walkfiles in os.walk(args.rootdir): | ||
| # don't visit certain dirs. This is just a performance improvement | ||
| # as we would prune these later in normalize_files(). But doing it | ||
| # cuts down the amount of filesystem walking we do and cuts down | ||
| # the size of the file list | ||
| for d in skipped_dirs: | ||
| if d in dirs: | ||
| dirs.remove(d) | ||
|
|
||
| for name in walkfiles: | ||
| pathname = os.path.join(root, name) | ||
| files.append(pathname) | ||
|
|
||
| files = normalize_files(files) | ||
|
|
||
| outfiles = [] | ||
| for pathname in files: | ||
| basename = os.path.basename(pathname) | ||
| extension = file_extension(pathname) | ||
| if extension in extensions or basename in extensions: | ||
| outfiles.append(pathname) | ||
| return outfiles | ||
|
|
||
| def get_regexs(): | ||
| regexs = {} | ||
| # Search for "YEAR" which exists in the boilerplate, but shouldn't in the real thing | ||
| regexs["year"] = re.compile( 'YEAR' ) | ||
| # dates can be 2014, 2015, 2016, ..., CURRENT_YEAR, company holder names can be anything | ||
| years = range(2014, date.today().year + 1) | ||
| regexs["date"] = re.compile( '(%s)' % "|".join(map(lambda l: str(l), years)) ) | ||
| # strip // +build \n\n build constraints | ||
| regexs["go_build_constraints"] = re.compile(r"^(// \+build.*\n)+\n", re.MULTILINE) | ||
| # strip #!.* from shell scripts | ||
| regexs["shebang"] = re.compile(r"^(#!.*\n)\n*", re.MULTILINE) | ||
| return regexs | ||
|
|
||
|
|
||
|
|
||
| def main(): | ||
| regexs = get_regexs() | ||
| refs = get_refs() | ||
| filenames = get_files(refs.keys()) | ||
|
|
||
| for filename in filenames: | ||
| if not file_passes(filename, refs, regexs): | ||
| print(filename, file=sys.stdout) | ||
|
|
||
| return 0 | ||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright YEAR The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
Oops, something went wrong.