Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify build 2 #14

Merged
merged 2 commits into from
Dec 22, 2023
Merged

simplify build 2 #14

merged 2 commits into from
Dec 22, 2023

Conversation

pepyakin
Copy link
Contributor

No description provided.

use symbolic link to fix the `cargo publish`
Copy link
Owner

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, smart. Will try to release this as RC and then check if Substrate builds.
The feature approach did not work - somehow substrate failed to build. Probably since cargo downloads the dependency without its workspace.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Owner

ggwpez commented Dec 22, 2023

Yea seems to build Substrate 👍

@ggwpez ggwpez merged commit fd32037 into ggwpez:master Dec 22, 2023
1 check passed
@ggwpez ggwpez mentioned this pull request Dec 22, 2023
ggwpez added a commit that referenced this pull request Dec 22, 2023
The `publish` feature should not be needed anymore after #14.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants