Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.use_standins_for_native_colors #129

Closed
Thorin-Oakenpants opened this issue May 23, 2017 · 3 comments
Closed

ui.use_standins_for_native_colors #129

Thorin-Oakenpants opened this issue May 23, 2017 · 3 comments

Comments

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented May 23, 2017

snip

@earthlng
Copy link
Contributor

Since the routine affected by the preference "ui.use_standins_for_native_colors" does not include nsLayoutUtils::GetColor, how can the patch fix the bug?

Since not even Arthur seems to understand what exactly the Tor patch fixes and neither does the mozilla dev, I'd say let's wait and see how the ticket evolves before we rush to include this

@atomGit
Copy link

atomGit commented May 28, 2017

ui.use_standins_for_native_colors makes tool-tips unreadable for me - the font color seems to be same as the background color (default theme on Linux)

from post above...

It has one particular bug with a particular color set, not a bug in blocking leakage of system colors: quote Arthur: "but that mode doesn't operate quite correctly when the desktop theme calls for white on black text".

@atomGit atomGit reopened this May 28, 2017
@atomGit
Copy link

atomGit commented May 28, 2017

Linux Mint 18.1

tool-tips always seem to have a black background color (unless set differently by the document i suppose) and, with this pref = true, the text also appears black

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants