New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "definitions" variable in JSF._parse method #35
Comments
I don’t think it is instead of definitions, it has a different usecase, it’s intention is to be overwritten while in subschemas. Looks like an additional feature and would need to maintain a subschema context rather than adding to the global context
PR’s welcome
…Sent from my iPhone
On 7 Jul 2022, at 06:38, jtyoung84 ***@***.***> wrote:
The latest JSON Schema draft versions recommend using $defs instead of definitions with the note that the actual reference pointer should be extracted from the $ref fragment. I think it will require a change in the _parse method of https://github.com/ghandic/jsf/blob/main/src/jsf/parser.py
—
Reply to this email directly, view it on GitHub<#35>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFTJMQLAVRFASZGPRGKZCTDVSXVFBANCNFSM523B43WQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
After perusing the release notes for draft 2019-09, |
Viable if we can get #3 fixed |
ccaroon
pushed a commit
to ccaroon/jsf
that referenced
this issue
Sep 28, 2022
Fixes ghandic#35 - Make "definitions" variable in JSF._parse method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest JSON Schema draft versions recommend using
$defs
instead ofdefinitions
with the note that the actual reference pointer should be extracted from the$ref
fragment. I think it will require a change in the_parse
method of https://github.com/ghandic/jsf/blob/main/src/jsf/parser.pyThe text was updated successfully, but these errors were encountered: