Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "definitions" variable in JSF._parse method #35

Closed
jtyoung84 opened this issue Jul 6, 2022 · 3 comments · Fixed by #37
Closed

Make "definitions" variable in JSF._parse method #35

jtyoung84 opened this issue Jul 6, 2022 · 3 comments · Fixed by #37

Comments

@jtyoung84
Copy link
Contributor

The latest JSON Schema draft versions recommend using $defs instead of definitions with the note that the actual reference pointer should be extracted from the $ref fragment. I think it will require a change in the _parse method of https://github.com/ghandic/jsf/blob/main/src/jsf/parser.py

@ghandic
Copy link
Owner

ghandic commented Jul 6, 2022 via email

@jtyoung84
Copy link
Contributor Author

After perusing the release notes for draft 2019-09, definitions was renamed to $defs with the caveat that definitions should still be honored for backwards compatibility. This might be a non-issue then if the jsf library currently only supports up to draft 7 (#3).

@ghandic
Copy link
Owner

ghandic commented Jul 12, 2022

Viable if we can get #3 fixed

ccaroon pushed a commit to ccaroon/jsf that referenced this issue Sep 28, 2022
Fixes ghandic#35 -  Make "definitions" variable in JSF._parse method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants