Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support enum of objects #103

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: support enum of objects #103

merged 1 commit into from
Mar 5, 2024

Conversation

simon-schoonjans
Copy link
Contributor

  • add support for enum of objects

    According to the json-schema specifcation elements in the enum array might be of any type, so that includes objects.

@simon-schoonjans simon-schoonjans changed the title feat: support enum of objects (#1) feat: support enum of objects Mar 5, 2024
ghandic
ghandic approved these changes Mar 5, 2024
View reviewed changes
Copy link
Owner

@ghandic ghandic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - a object based enum sounds horrific 😅 but the spec allows it!

@ghandic ghandic merged commit 46684c6 into ghandic:main Mar 5, 2024
@ghandic
Copy link
Owner

ghandic commented Mar 5, 2024

I'll do a release for this in the coming days 🤙🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghandic ghandic ghandic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simon-schoonjans @ghandic