Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support not nullable type list #62

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

mschwab12
Copy link
Contributor

  • added support for not nullable list of types in parser
  • added sample json for not nullable list of types
  • added test case for not nullable list of types

* added support for not nullable list of types in parser
* added sample json for not nullable list of types
* added test case for not nullable list of types
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 99.15% // Head: 99.16% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (d8c8c52) compared to base (22fa798).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   99.15%   99.16%   +0.01%     
==========================================
  Files          31       31              
  Lines        1060     1074      +14     
==========================================
+ Hits         1051     1065      +14     
  Misses          9        9              
Impacted Files Coverage Δ
jsf/parser.py 99.29% <100.00%> (+0.01%) ⬆️
jsf/tests/test_default_fake.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghandic ghandic merged commit 115db61 into ghandic:main Jan 19, 2023
@ghandic
Copy link
Owner

ghandic commented Jan 20, 2023

Thanks for the contrib! This will be included in 0.7.1 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants