Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use valid pydantic field name #78

Closed
wants to merge 1 commit into from

Conversation

mtache
Copy link

@mtache mtache commented Aug 2, 2023

The following change in pydantic breaks jsf: pydantic/pydantic#6797
It is part of pydantic 2.1
Partial traceback:

File jsf/schema_types/base.py:15
     11 class ProviderNotSetException(Exception):
     12     ...
---> 15 class BaseSchema(BaseModel):
     17     type: Optional[Union[str, List[str]]] = None

NameError: Fields must not use names with leading underscores; e.g., use 'schema' instead of '_schema'.

Renamed invalid '_schema' field name to 'json_schema'.

@ghandic
Copy link
Owner

ghandic commented Aug 21, 2023

Fixed in #77

@ghandic ghandic closed this Aug 21, 2023
@mtache mtache deleted the fix/pydantic_invalid_field branch August 22, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants