Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get issue list of the repository #129

Closed
adhrinae opened this issue Feb 25, 2022 · 1 comment · Fixed by #131
Closed

Cannot get issue list of the repository #129

adhrinae opened this issue Feb 25, 2022 · 1 comment · Fixed by #131

Comments

@adhrinae
Copy link

First of all, Thanks for the great work 👍 .

As a maintainer of some projects, I open the GitHub Issues page a lot.
Sometimes I want to open a specific issue number without opening the issues page because I remember the issue number.

Even though your workflow supports that feature, It seems not working at the moment.

Environment

  • x86 Mac (not tested on M1 mac yet)
  • macOS 12.2.1
  • PHP 8 is installed

Steps of Reproduce

  1. Type gh and any arbitrary repository. for example, this repo.
  2. Type Space and #. and wait for any results to come out. Or Enter specific issue number like #20
  3. Nothing happens

Error log

Notice: Undefined property: stdClass::$pull_request in {MASKED}/{WORKFLOW_FOLDER}/search.php on line 405
@tobias-grasse
Copy link
Contributor

I have the same issue. For a quick fix, change line 405 of search.php to ->icon(isset($issue->pull_request) ? 'pull-request' : 'issue'). This prevents the undefined property error in case the given number is an issue and not a PR number. I'll open a PR right now 🙂

@gharlan Thank you for this workflow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants