Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GHC 8.2 #602

Closed
cocreature opened this issue Aug 4, 2017 · 20 comments
Closed

Support for GHC 8.2 #602

cocreature opened this issue Aug 4, 2017 · 20 comments

Comments

@cocreature
Copy link

As everyone is surely aware, GHC 8.2 has been released and it would be great if we could update ghcjs for it.

I’ve started doing so by just trying to build using ghc-8.2 and fixing compile errors. While I have made some progress, there’s still quite a bit to do until it compiles (we’ll see if it works once it compiles ;)) so I’m opening this issue to a) avoid other people duplicating the work that I’ve already done and b) as a call for collaboration: I’m really just a user and know little about the internals of ghc and ghcjs so I’m more than happy to collaborate with anybody also interested in GHC 8.2 support.

@luite
Copy link
Member

luite commented Aug 4, 2017 via email

@dmjio
Copy link

dmjio commented Aug 4, 2017

@luite, fantastic to hear, and thank you. Does this include work on GHCJSi for 8.2 as well?

@bitonic
Copy link
Contributor

bitonic commented Aug 28, 2017

hey @luite , are there any updates on this work?

@qrilka
Copy link

qrilka commented Oct 18, 2017

winter is coming... could it bring us new GHCJS (maybe even with stack)?

@luite
Copy link
Member

luite commented Nov 3, 2017 via email

@dmjio
Copy link

dmjio commented Nov 3, 2017

Sounds awesome @luite, can you comment at all on GHCJSi under GHC 8.2?

@luite
Copy link
Member

luite commented Nov 3, 2017 via email

@cocreature
Copy link
Author

@luite Thank you so much for working on this! If there is any way to help, let me know and I’ll see what I can do (although I’m not very familiar with GHC’s and GHCJS’ internals).

@wdanilo
Copy link

wdanilo commented Dec 17, 2017

@luite Do you know any estimates when will it be available in Master? it is insalely important thing in the ghcjs world i think :)

@luite
Copy link
Member

luite commented Dec 19, 2017

the biggest blocker was #617 (with GHC 8.2 it was affecting Template Haskell splices much more often than with 8.0, basically making it unusable on my test machine). I finally have a proper fix for that now.

What remains is some smaller bugs that don't look too hard to fix and some updates for the booter program. I'm not sure if I can do it before Christmas, but before the end of the year looks doable. Thanks for your patience.

@Mikolaj
Copy link

Mikolaj commented Jan 26, 2018

Completely off-topic, as a "thank you" for the 8.2 branch. :)

https://twitter.com/puffnfresh/status/956440036882313216

BTW, @luite, how is it going? Good time to test now, or will you shout when it's ready?

@mlitchard
Copy link

@luite yes, please give a shout out when it's time to test. :)

@luite
Copy link
Member

luite commented Feb 4, 2018

there are still a few failures with packages that used to work with 8.0, so I wouldn't quite rely on 8.2 just yet.

@RobertFischer
Copy link

Anything we can help with?

@luite
Copy link
Member

luite commented Feb 20, 2018

One thing that comes to mined is that the /utils/makePackages.sh script still has some rough edges, see #629 .

After we have a way to quickly initialize the source tree, we can hopefully fix the CI.

@luite
Copy link
Member

luite commented May 7, 2018

script now fixed

@luite luite closed this as completed May 7, 2018
@wdanilo
Copy link

wdanilo commented May 7, 2018

Wooooohooo!! So we're going to have new GHC with GHCJS?

@luite
Copy link
Member

luite commented May 7, 2018

The ghc-8.2 and ghc-8.4 branches should work now. I'm doing my new development work on 8.4, but both should be usable now.

The only somewhat serious regression of 8.4 vs 8.2 that I know of is #651, so perhaps hold off 8.4 for a bit longer if you need profiling.

@wdanilo
Copy link

wdanilo commented May 7, 2018

Thats really awesome @luite. I don't even know how to thank you for such impressive work on it. Could you also reveal if there are any plans to just merge it into master and have a "stable" 8.* release?

@LukaHorvat
Copy link

Does it work on Windows now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants