-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for GHC 8.2 #602
Comments
I'm working on this and can already build the compiler (and tools like
haddock, ghcjs-pkg) on GHC 8.2 and Cabal 2.
I'm now working on the boot program (I'd like to drop the stage 2 packages
to make GHCJS more stack lts and nix friendly), a library update and on
making the generated code actually work.
…On Fri, Aug 4, 2017, 08:50 Moritz Kiefer ***@***.***> wrote:
As everyone is surely aware, GHC 8.2 has been released and it would be
great if we could update ghcjs for it.
I’ve started doing so <https://github.com/cocreature/ghcjs/tree/ghc-8.2>
by just trying to build using ghc-8.2 and fixing compile errors. While I
have made some progress, there’s still quite a bit to do until it compiles
(we’ll see if it works once it compiles ;)) so I’m opening this issue to a)
avoid other people duplicating the work that I’ve already done and b) as a
call for collaboration: I’m really just a user and know little about the
internals of ghc and ghcjs so I’m more than happy to collaborate with
anybody also interested in GHC 8.2 support.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#602>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVnMOJkDBbuOyRYZwNtVIPlurS-UAcZks5sUr85gaJpZM4OtV3m>
.
|
@luite, fantastic to hear, and thank you. Does this include work on |
hey @luite , are there any updates on this work? |
winter is coming... could it bring us new GHCJS (maybe even with stack)? |
Sorry for the delays.
I now have GHCJS working on 8.2 at least to the point that it passes most
of the testsuite. The (global) packages have been reduced to basically the
dependencies of Cabal and Template Haskell (base, ghc-prim, directory,
filepath, time, bytestring ghcjs-prim etc.). Most notably, ghcjs-base is
now a normal package. That should make the packages a bit easier to deal
with for for example Stack LTS or Nix.
The metadata packer still needs to be updated (building with -debug works
though) and ghcjs-boot also still needs some updates (I patched/copied some
things in place by hand for testing the changes); I will try to find some
time for that this weekend and then push the new branch.
Join points are (still) supported (but required a bit of rework), but I
haven't investigated the performance impact of the improved join point
support in the 8.2 frontend.
GHC 8.2's STG has a new construct for top level string literals. These may
allow for some additional optimization, but it looks like initially they
defeat some (rather ad hoc) GHCJS optimizations for strings. I will look
into improving that.
…On Wed, Oct 18, 2017, 16:12 Kirill Zaborsky ***@***.***> wrote:
winter is coming...could it bring us new GHCJS (maybe even with stack)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#602 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVnMFyTZucpbB0EqZlzYXgF28EUTWWDks5stbLrgaJpZM4OtV3m>
.
|
Sounds awesome @luite, can you comment at all on |
GHCJSi doesn't work yet (just like the incremental relinker I talked about
at Bayhac, but didn't get acceptable performance with at the time) but
should follow after.
…On Fri, Nov 3, 2017, 11:04 David Johnson ***@***.***> wrote:
Sounds awesome @luite <https://github.com/luite>, can you comment at all
on GHCJSi under GHC 8.2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#602 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVnMBIHxJBaXSpYqNZ1WqcRoaHy-9Lnks5syoLKgaJpZM4OtV3m>
.
|
@luite Thank you so much for working on this! If there is any way to help, let me know and I’ll see what I can do (although I’m not very familiar with GHC’s and GHCJS’ internals). |
@luite Do you know any estimates when will it be available in Master? it is insalely important thing in the ghcjs world i think :) |
the biggest blocker was #617 (with GHC 8.2 it was affecting Template Haskell splices much more often than with 8.0, basically making it unusable on my test machine). I finally have a proper fix for that now. What remains is some smaller bugs that don't look too hard to fix and some updates for the booter program. I'm not sure if I can do it before Christmas, but before the end of the year looks doable. Thanks for your patience. |
Completely off-topic, as a "thank you" for the 8.2 branch. :) https://twitter.com/puffnfresh/status/956440036882313216 BTW, @luite, how is it going? Good time to test now, or will you shout when it's ready? |
@luite yes, please give a shout out when it's time to test. :) |
there are still a few failures with packages that used to work with 8.0, so I wouldn't quite rely on 8.2 just yet. |
Anything we can help with? |
One thing that comes to mined is that the After we have a way to quickly initialize the source tree, we can hopefully fix the CI. |
script now fixed |
Wooooohooo!! So we're going to have new GHC with GHCJS? |
The The only somewhat serious regression of 8.4 vs 8.2 that I know of is #651, so perhaps hold off 8.4 for a bit longer if you need profiling. |
Thats really awesome @luite. I don't even know how to thank you for such impressive work on it. Could you also reveal if there are any plans to just merge it into master and have a "stable" 8.* release? |
Does it work on Windows now? |
As everyone is surely aware, GHC 8.2 has been released and it would be great if we could update
ghcjs
for it.I’ve started doing so by just trying to build using
ghc-8.2
and fixing compile errors. While I have made some progress, there’s still quite a bit to do until it compiles (we’ll see if it works once it compiles ;)) so I’m opening this issue to a) avoid other people duplicating the work that I’ve already done and b) as a call for collaboration: I’m really just a user and know little about the internals ofghc
andghcjs
so I’m more than happy to collaborate with anybody also interested in GHC 8.2 support.The text was updated successfully, but these errors were encountered: