Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jsaddle-wkwebview builds #100

Merged
merged 2 commits into from Jul 19, 2019
Merged

Fix jsaddle-wkwebview builds #100

merged 2 commits into from Jul 19, 2019

Conversation

matthewbauer
Copy link
Contributor

Newer nixpkgs resulted in errors like:

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSURL", referenced from:
      objc-class-ref in libHSjsaddle-wkwebview-0.9.6.0-3Qa6qfm5Iv91uqRz8CkhhF.a(WKWebView.o)
ld: symbol(s) not found for architecture x86_64

This adds darwin.cf-private which has this symbol, which swift corefoundation lacks.

@matthewbauer
Make default.nix’s haskellPackages a named argument
176a073 
This makes things easier to pass in. By default, we use nixpkgs’
haskellPackages.
@matthewbauer
Update jsaddle-wkwebview to work with newer Nixpkgs
cf8445b
matthewbauer added a commit to reflex-frp/reflex-platform that referenced this pull request Jul 19, 2019
@matthewbauer
Update jsaddle-wkwebview override to add cf-private correctly
601999f 
This resolves the

Upstream prs:

- ghcjs/jsaddle#100
- NixOS/nixpkgs#65048
@hamishmack hamishmack merged commit bf2921c into ghcjs:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewbauer @hamishmack