win32: add fprintf to grt_save_backtrace #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eine
force-pushed
the
fix/win32
branch
2 times, most recently
from
f6f429e
to
08c3c3f
Compare
|
You should really add a comment to explain why there is a dummy printf. |
eine
added
CI: GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, I don't know how to explain this. Since MSYS2 recipes were modifidied for using clang when building with LLVM backend (#1497), one test has been failing in CI: issue635. It is difficult to debug, because I cannot reproduce locally.
The issue is that the exit code is
3, when it should be0. I run the test on GDB in CI, and I could confirm that: https://github.com/eine/ghdl/runs/1422980823?check_suite_focus=true#step:8:64. Then, Tristan told me that the issue might be insrc/grt/config/win32.c. Hence, I added someprintfstatements, to see which functions are used. Surprisingly, that fixed the issue. I removed the print statements one by one, until I came to this minimal "fix".So, adding an empty printf statement to
grt_save_backtracefixes the issue, but I cannot explain why.