-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPI: add support for detecting ports and their directions #753
Conversation
This is OK, but some builds are failing due to trailing spaces. Can you remove them ? |
@tgingold should ports with VhpiBufferMode be treated as vpiOutput or vpiInout instead of vpiNoDirection? |
@tgingold I fixed the indentation issue but travis is still failing and I can't tell the reason |
@xnorme it is failing because of gna/issue450. It expects the output in |
Thanks @1138-4eb. I had missed the point that a |
Thanks! Bonus point if buffer ports are also considered as vpiOutput. |
Description
The changes enable
vpi_get(vpiType, handle_to_port)
to returnvpiPort
if the signal is a port. It also enablesvpi_get(vpiDirection, handle_to_port)
to return correct port directions(vpiInput
,vpiOutput
, orvpiInout
).The changes does not change behavior for other types of signals.
🚨 Before submitting your PR, please read contribute in the Docs, and review the following checklist:
When contributing to the GHDL codebase...
When contributing to the docs...
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.
❤️ Thank you!