Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for new LOCATION url syntax in django-redis >= 3.8.0 #23

Closed
wants to merge 1 commit into from

Conversation

slafs
Copy link

@slafs slafs commented Jun 9, 2015

I've added some new schemes and unified the syntax for UNIX based URLs as well as the standard HOST:PORT ones. I tried to do this as much unobtrusive as I could.

@ghickman ghickman added this to the 1.0 milestone Jun 12, 2015
@slafs
Copy link
Author

slafs commented Jun 12, 2015

Oh, this also adds support for the new path for the backend (django_redis.cache.RedisCache).

I noticed that Travis reported errors for python 2.6. I looked into it and It seems that python2.6 urlparse handles path and query differently than in other versions. Don't know exactly how to address this and also avoid bloat... Maybe some compat module would be suitable here?

@ghickman
Copy link
Owner

@slafs – thanks for taking the time to raise these changes.

Are the new schemes (djredis, djrediss, djhiredis, djhirediss, djredisunix, djhiredisunix) what django-redis >= 3.8.0 adds? Could you point me at a documentation link if you have one?

As for the unified syntax for UNIX urls could you take that out of your patch please? It's very hard for me to pull apart the difference between those changes and the scheme ones and a PR should only introduce one change.

I'm hoping to roll a 1.0 release very soon and would love to have the updated scheme changes in that if possible. I'll also be rolling in #17 so it would be great if you could base your changes off those too (they're pushed in the 1.0-release branch) which will sort out the python 2.6 urlparse issue you saw.

@slafs
Copy link
Author

slafs commented Jun 14, 2015

Hey!
Docs for the new syntax are here.

As for the UNIX case I guess I just wanted to show that there's no need to do hackery things like in the current implementation and those URLs can be easily handled the same way as the rest of cases. So maybe we can keep this here?

Will try to make my changes on top of #17.

@ghickman
Copy link
Owner

@slafs – thanks for the docs link!

I've been doing all the 1.0 work in the 1.0-release branch today so if you check that out it's got #17 as the base with a bunch of other changes on top.

@ghickman ghickman removed this from the 1.0 milestone Jul 14, 2015
@ghickman ghickman self-assigned this Dec 19, 2016
@ghickman
Copy link
Owner

@slafs – thanks for all your contributions to the project but I've decided to deprecate in favour of Django Environ.

@ghickman ghickman closed this May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants