Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to set the message identifier #1

Closed
wants to merge 2 commits into from
Closed

Add an option to set the message identifier #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4861cd5
Import settings from sentry instead of django
ghickman Apr 16, 2012
b886382
Let the user decide what to display in the first section of the message
ghickman Apr 14, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 25 additions & 2 deletions sentry_groveio/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"""

from django import forms
from django.conf import settings

from sentry.conf import settings
from sentry.plugins import Plugin, register

import urllib
Expand All @@ -19,9 +19,15 @@
logger = logging.getLogger('sentry.plugins.groveio')


form_options = (
('project.name', 'Project Name'),
('server_name', 'Server Name')
)

class GroveIoOptionsForm(forms.Form):
token = forms.CharField(help_text="Your Grove.io channel token.")
service_name = forms.CharField(help_text="Name of the service (displayed in the message)", initial='Sentry')
message_identifier = forms.ChoiceField(choices=form_options, help_text='')
url = forms.CharField(help_text="(Optional) Service URL for the web client", required=False)
icon_url = forms.CharField(help_text="(Optional) Icon for the service", required=False)

Expand All @@ -40,13 +46,30 @@ class GroveIoMessage(Plugin):
def is_configured(self, project):
return all((self.get_option(k, project) for k in ('token', 'service_name')))

def get_message_identifier(self, event):
"""
Take the option selected in the management form and turn it into an
object attribute to get the string we need.
"""
method = self.get_option('message_identifier', event.project)
if not method:
# in case this option hasn't been set before
return getattr(event, 'server_name')
instance = event
for attr in method.split('.'):
instance = getattr(instance, attr)
return instance

def post_process(self, group, event, is_new, is_sample, **kwargs):
if not is_new:
return
token = self.get_option('token', event.project)
service = self.get_option('service_name', event.project)
if token and service:
message = '[%s] %s: %s' % (event.server_name, event.get_level_display().upper(), event.error().encode('utf-8').split('\n')[0])
message = '[%s] %s: %s' % (
self.get_message_identifier(event),
event.get_level_display().upper(),
event.error().encode('utf-8').split('\n')[0])
self.send_payload(token, service, event, group, message)

def send_payload(self, token, service, event, group, message):
Expand Down