Fix typo

ghiggi · Jun 5, 2024 · bd226cb · bd226cb
1 parent 3afa5d9
commit bd226cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pycolorbar/settings/colorbar_validator.py b/pycolorbar/settings/colorbar_validator.py
@@ -110,6 +110,7 @@ def validate_colors(cls, v):
                     isinstance(color_component, (int, float)) and 0 <= color_component <= 1 for color_component in v
                 ):
                     raise ValueError("Invalid RGB/RGBA format. Expected tuple with values between 0 and 1.")
+                v = tuple(v)
             else:
                 raise ValueError("Invalid color format. Expected a named color, hex string, or RGB/RGBA tuple.")
         return v

diff --git a/pycolorbar/tests/test_colorbar_validator.py b/pycolorbar/tests/test_colorbar_validator.py
@@ -177,7 +177,7 @@ def test_invalid_n(self, n):
         [
             "#ff0000",  # valid hex
             (1, 0, 0),  # valid RGB tuple
-            [1, 0, 0],  # valid RGB tuple
+            [1, 0, 0],  # valid RGB list
             (1, 0, 0, 1),  # valid RGBA tuple (if bad/over/under alpha provided ... RGB alpha will be overwritten !)
             "red",  # valid named color
             "none",
@@ -187,8 +187,8 @@ def test_valid_colors(self, color):
         """Test valid colors for 'bad_color', 'over_color', 'under_color'."""
         cmap_settings = {"name": "viridis", "bad_color": color, "over_color": color, "under_color": color}
         validated = ColormapSettings(**cmap_settings)
-        if isinstance(color, tuple):
-            color = list(color)
+        if isinstance(color, list):
+            color = tuple(color)
         assert validated.bad_color == color
         assert validated.over_color == color
         assert validated.under_color == color