Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor codestyle #16

Merged
merged 29 commits into from
Apr 2, 2024
Merged

Refactor codestyle #16

merged 29 commits into from
Apr 2, 2024

Conversation

ghiggi
Copy link
Owner

@ghiggi ghiggi commented Apr 2, 2024

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow :
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

Summary

This PR add several ruff rules to improve code quality of the software.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.65%. Comparing base (2cdd9bb) to head (e84b047).

Files Patch % Lines
ximage/accessor/methods.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   97.39%   97.65%   +0.25%     
==========================================
  Files          12       12              
  Lines         846      809      -37     
==========================================
- Hits          824      790      -34     
+ Misses         22       19       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiggi ghiggi merged commit bb65f42 into main Apr 2, 2024
24 of 29 checks passed
@ghiggi ghiggi deleted the refactor-code-style branch April 2, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant