-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using scala-collection-compat together with silencer-plugin is broken #63
Comments
What Scala version is this? |
2.11.12, I think. When we upgraded Trying to add it back is still causing these issues: zio/izumi-reflect#128 |
I faced the very same problem when trying to bump |
@ghik are you planing on making a release soon? |
@sideeffffect there should be 1.7.2 soon, see https://github.com/ghik/silencer/actions |
For the record, it solves the issue we had in izumi-reflect zio/izumi-reflect#128 |
I see the plugin got published for Scala 2.12.13, but not for other versions. @ghik, is that intentional? |
@rdesgroppes mvnrepository.com seems to be out of sync, search.maven.org shows other versions |
Thanks, @ghik, I indeed see more Scala versions there: https://search.maven.org/search?q=g:com.github.ghik%20AND%20a:silencer-plugin_*%20AND%20v:1.7.2 |
@rdesgroppes yes, I don't cover all minor Scala versions because that would be a cross-building nightmare considering all the minor changes that might be introduced into the compiler API with every minor Scala version. In this case, 2.12.13 broke compatibility of error reporting API with 2.12.12 so I decided to drop 2.12.12 and assumed users can bump their Scala version. |
@ghik Fair enough. But, since:
... should a further note be added to https://github.com/ghik/silencer/blob/master/README.md#silencer-scala-compiler-plugin-for-warning-suppression so that |
@rdesgroppes Since you're bound by Scala version used by sbt, I'm assuming you are developing an sbt plugin? I'm not familiar with sbt plugin development but in principle you should be able to force 2.12.13 to be used in your plugin. This should work because minor Scala versions are supposed to be both backwards and forward compatible. |
When the
scala-collection-compat
library is used together with thesilencer-plugin
compiler plugin, you get errors like this:Workaround is to drop
silencer-plugin
, but that might not be the desired solution.It's worth to note that
scala-collection-compat
defines its ownnowarn
annotation: https://github.com/scala/scala-collection-compat/blob/master/compat/src/main/scala-2.11_2.12/scala/annotation/nowarn.scalaRelated:
zio/izumi-reflect#121
scala/scala-collection-compat#413 (comment)
scala/scala-collection-compat#417
/cc @SethTisue @ekrich
continuation of scala/scala-collection-compat#418
The text was updated successfully, but these errors were encountered: