Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Native 0.4.0 #121

Merged
merged 10 commits into from
Jan 27, 2021
Merged

Scala Native 0.4.0 #121

merged 10 commits into from
Jan 27, 2021

Conversation

sideeffffect
Copy link
Member

@sideeffffect sideeffffect commented Jan 19, 2021

closes #126

@sideeffffect
Copy link
Member Author

Why doesn't the CI run for this PR? /cc @neko-kai

@neko-kai
Copy link
Member

neko-kai commented Jan 19, 2021

@sideeffffect Seems like that fixed it. I pushed these changes to develop, so you may rebase and remove my commits from the branch

@sideeffffect
Copy link
Member Author

sideeffffect commented Jan 19, 2021

Seems like we depend on ScalaTest 😄
scalatest/scalatest#1956

@sideeffffect
Copy link
Member Author

Blocked on scala/scala-collection-compat#413

@sideeffffect
Copy link
Member Author

blocked on #125

@sideeffffect
Copy link
Member Author

@neko-kai how do we make sure, that the Scala Native 0.4.0 artifact is published not just for 2.11, but also for 2.12 and 2.13?

@neko-kai
Copy link
Member

@sideeffffect
Try adding other versions to nativePlatform.language field in Deps.sc. (e.g. same as in jsPlatform)

@sideeffffect
Copy link
Member Author

We're green 🎉

@neko-kai neko-kai merged commit 5598f28 into zio:develop Jan 27, 2021
@neko-kai
Copy link
Member

@sideeffffect Thank you very much for your effort! 🙏

@sideeffffect sideeffffect deleted the patch-1 branch January 27, 2021 12:25
@sideeffffect
Copy link
Member Author

Happy to help! Will you be releasing v1.0.0-M13 anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants