Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailview Scrollbar #180

Closed
Yuof opened this issue May 8, 2019 · 6 comments · Fixed by #202
Closed

Detailview Scrollbar #180

Yuof opened this issue May 8, 2019 · 6 comments · Fixed by #202

Comments

@Yuof
Copy link

Yuof commented May 8, 2019

I'm submitting a bug report

  • Library Version:
    2.5.5

  • Browser:
    all

Current behavior:
When using Detailview the Detailcomponent always has a Scrollbar even if its small enough to fit.

Reproduce:

  1. https://ghiscoding.github.io/Angular-Slickgrid/#/rowdetail
  2. Open a Detailview
  3. Every Detailview has a Scrollbar

Expected/desired behavior:
No scrollbar if component is small enough.

@ghiscoding
Copy link
Owner

Ah I thought I had fixed that in the core lib, as it was discussed here, but it looks like I was waiting for an answer and push a commit without the change. I'll make another PR on the core lib soon, but it might take a few weeks before any new release is out on the core lib since it's not updated as often.

In the mean time, I'm not sure if that would work, but the problem is on the <div class="detail-container">, the min-height has to be removed. I did not tested it, but maybe trying to reset the min-height like this would work !?

.detail-container {
  min-height: initial !important;
}

or set it to 0 if that didn't work.

@Yuof
Copy link
Author

Yuof commented May 8, 2019

Ah I thought I had fixed that in the core lib, as it was discussed here, but it looks like I was waiting for an answer and push a commit without the change. I'll make another PR on the core lib soon, but it might take a few weeks before any new release is out on the core lib since it's not updated as often.

In the mean time, I'm not sure if that would work, but the problem is on the <div class="detail-container">, the min-height has to be removed. I did not tested it, but maybe trying to reset the min-height like this would work !?

.detail-container {
  min-height: initial !important;
}

or set it to 0 if that didn't work.

I tried both and none worked. It still gets overwritten somewhere.

@ghiscoding
Copy link
Owner

If that didn't work, you'll have to wait for the fix to be available in the core lib (6pac/SlickGrid). Like I said, this might take few weeks though.

@Yuof
Copy link
Author

Yuof commented May 8, 2019

document.getElementsByClassName("detail-container")[0].setAttribute("style", "min-height: 0;");
worked as an hack for now.

Thank you for the advice!

@ghiscoding
Copy link
Owner

ghiscoding commented May 9, 2019

PR #370 raised and merged on core lib.
We just have to wait for a new version release of the core lib, which I don't have any control over

ghiscoding added a commit that referenced this issue May 24, 2019
fix(rowDetail): update to latest SlickGrid version, fixes #180
@ghiscoding
Copy link
Owner

ghiscoding commented May 24, 2019

Now released under version 2.7.0

You can also up vote ⭐️ if you like the lib
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants