Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(services): remove gridOptions and columnDefinitions references #28

Merged
merged 1 commit into from
May 15, 2018

Conversation

ghiscoding
Copy link
Owner

Remove all gridOptions and columnDefinitions references from all Services.
The reasons of doing so

  • we have access to the Grid Options and Column Definitions from the Grid object
  • simplify all init and creation of Services
  • we can be more dynamic, user can change some Grid Options dynamically and they will be available in all Services since we are getting them from the Grid object when the time comes, so if options changed, we will see the latest.

Related to issue #20

@ghiscoding ghiscoding merged commit 63f64e6 into master May 15, 2018
@ghiscoding ghiscoding deleted the refactor/services-references branch May 25, 2018 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant