Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use DataView transactions with multiple item changes #527

Merged
merged 2 commits into from Jul 17, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 16, 2020

  • we should use DataView transactions as much as possible when dealing with multiple items (array) in 1 call, that is true for (addItems, deleteItems, updateItems)
    • DataView beginUpdate ... endUpdate

- we should use DataView transactions as much as possible when dealing with multiple items (array) in 1 call, that is true for (addItems, deleteItems, updateItems)
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #527 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #527    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9634      9643     +9     
  Branches      3227      3365   +138     
==========================================
+ Hits          9634      9643     +9     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <ø> (ø)
...modules/angular-slickgrid/services/grid.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f958d...b58a535. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants