Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation doesn't work just as in #30 #39

Closed
5 tasks done
SirMathelot opened this issue Dec 12, 2022 · 3 comments
Closed
5 tasks done

Installation doesn't work just as in #30 #39

SirMathelot opened this issue Dec 12, 2022 · 3 comments

Comments

@SirMathelot
Copy link

SirMathelot commented Dec 12, 2022

Describe the bug

When I add AngularMarkdownEditorModule.forRoot() to imports in app.module I get.

Value at position 5 in the NgModule.imports of AppModule is not a reference
Value could not be determined statically.(-991010)
app.module.ts(40, 5): Unable to evaluate this expression statically.
app.module.ts(40, 5): A value for 'forRoot' cannot be determined statically, as it is an external declaration.

When I add AngularMarkdownEditorModule without the .forRoot() and add the tag I get the same error as in #30.

Reproduction

I downloaded the whole repo as it contains the newest demo and then did npm i angular-markdown-editor. I changed the 11th line in app.module from import { AngularMarkdownEditorModule } from '../lib/angular-markdown-editor'; to import { AngularMarkdownEditorModule } from 'angular-markdown-editor';.

Environment Info

Angular 14.1.0
angular-markdown-editor 3.0
typescript 4.7.4

Validations

@NumanTeleprompter
Copy link

I am also receiving the same, followed every step of the How To.

Angular 14.2.10
Angular Markdown Editor 4.3.0
TypeScript 4.6.4

@ghiscoding
Copy link
Owner

ghiscoding commented Dec 12, 2022

Thanks for reporting, it should be all good now, it seems that newer version of Angular for Ivy requires really strict Typings for the NgModule returned by the lib. I also updated the demo since I saw that I forgot to update it with latest and that helped finding the issue, the live demo build is now fully working. I didn't check the how to Wiki, but the live demo should always be the reference anyway

@NumanTeleprompter
Copy link

NumanTeleprompter commented Dec 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants