Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @Output events #41

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Added @Output events #41

merged 1 commit into from
Apr 3, 2023

Conversation

JordanW9232
Copy link

@JordanW9232 JordanW9232 commented Apr 2, 2023

  • Added @output decorator for all events so they will be recognized in angular html templates.
  • The EventEmitters will never actually emit any events though, since bootstrap-markdown is already emitting events, we can't use the EventEmitters or else the events will get fired twice.
  • I chose to make all the event emitters private just in case someone ever used @ViewChild or @ViewChildren and tried to access them and found that they don't actually do anything.
  • fixes Missing Typings for Event Hooks in HTML Template #40

@ghiscoding ghiscoding merged commit 88e198e into ghiscoding:master Apr 3, 2023
2 checks passed
@ghiscoding
Copy link
Owner

great I didn't think it was that simple, I'll merge and push a release sometime this week. Please remind me if I forget to release it within a week. Thanks for your contribution

@ghiscoding
Copy link
Owner

@JordanW9232 sorry for the delay and thanks again for the great contribution, now released under v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Typings for Event Hooks in HTML Template
3 participants