Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row detail view + sorting + filtering + expanding Headline / master #949

Closed
5 tasks done
rgrosser71 opened this issue Jul 4, 2022 · 2 comments · Fixed by #950
Closed
5 tasks done

Row detail view + sorting + filtering + expanding Headline / master #949

rgrosser71 opened this issue Jul 4, 2022 · 2 comments · Fixed by #950
Labels

Comments

@rgrosser71
Copy link

rgrosser71 commented Jul 4, 2022

Describe the bug

Hi,

in the header are the additional Placholder-Columns placed at end not at beginning
(in function "changeColumnsArrangement"seems not to be called)
so if you click on the Header for sorting ist works on the wrong collumn.

You could see it on your own testpage.

Reproduction

look at https://ghiscoding.github.io/Angular-Slickgrid/#/rowdetail

-click at header for sorting
-look at filter-header
-look at expand-header
OLD angular-slickgrid.js
NEW gridState.service.js =>changeColumnsArrangement => if (this._gridOptions.enableRowDetailView) {

Environment Info

"@angular/core": "~14.0.4",
    "@slickgrid-universal/common": "^1.3.0",
    "@slickgrid-universal/excel-export": "^1.3.0",
    "@slickgrid-universal/text-export": "^1.3.0",
    "angular-slickgrid": "^4.2.1",
    "Microsoft Edge": "Version 103.0.1264.44 (Offizielles Build) (64-Bit)",
    "typescript": "~4.7.4"

Validations

@rgrosser71 rgrosser71 changed the title Row with detail view + sorting + filtering + expanding Headline / master Row detail view + sorting + filtering + expanding Headline / master Jul 4, 2022
ghiscoding-SE pushed a commit that referenced this issue Jul 5, 2022
- fixes #949
- Row Detail extension columns were offset by 1 column (ie, clicking on 2nd column would sort 1st column), internally the RowDetail extension has to be instantiated a little bit more early within Angular-Slickgrid for it to properly sync columns and so on
- added couple more Cypress E2E tests to cover the Sorting icons to be displayed under the expected column
@ghiscoding
Copy link
Owner

@rgrosser71
Thanks for the feedback, I didn't even noticed it and this was probably broken since version 3.x. I found the issue and added Cypress E2E test to make sure it doesn't happen again the future. I'll release a new patch version sometime today or tomorrow. Thanks again

ghiscoding added a commit that referenced this issue Jul 5, 2022
fix(plugin): Row Detail column sorting was offset, fixes #949
@ghiscoding
Copy link
Owner

ghiscoding commented Jul 5, 2022

Released a new version v4.1.2 with the Row Detail fix, the Example 21 was updated and now works correctly and has extra E2E tests covering the fix. Thanks for the feedback, cheers and happy coding ⭐

@ghiscoding ghiscoding added the bug label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants