Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid options registerExternalResources are no longer working for me #956

Closed
5 tasks done
roopeshkurian opened this issue Jul 7, 2022 · 5 comments
Closed
5 tasks done

Comments

@roopeshkurian
Copy link

Describe the bug

In the grid options section I am using excel export.

registerExternalResources: [new ExcelExportService()],

But now I am getting an error.

Type 'ExcelExportService' is not assignable to type 'ExternalResource'.

Error: component.ts:284:35 - error TS2322: Type 'ExcelExportService' is not assignable to type 'ExternalResource'. Types of property 'init' are incompatible.
Type '(grid: SlickGrid, containerService: ContainerService) => void' is not assignable to type '(grid: SlickGrid, container: ContainerService) => void'.
Types of parameters 'grid' and 'grid' are incompatible.
Type 'import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/slickGrid.interface").SlickGrid' is not assignable to type 'import("node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/slickGrid.interface").SlickGrid'.
Types of property 'editActiveCell' are incompatible.
Type '(editor: import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editor.interface").Editor | import("node_modules/angular-slickgrid/node_m...' is not assignable to type '(editor: import("node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editor.interface").Editor | import("node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/sl...'.
Types of parameters 'editor' and 'editor' are incompatible.
Type 'import("node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editor.interface").Editor | import("node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/slickCompos...' is not assignable to type 'import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editor.interface").Editor | import("node_modules/angular-slickgrid/node_modules/@s...'.
Type 'Editor' is not assignable to type 'Editor | SlickCompositeEditor'.
Type 'import("/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editor.interface").Editor' is not assignable to type 'import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editor.interface").Editor'.
Types of property 'init' are incompatible.
Type '(args?: import("@slickgrid-universal/common/dist/commonjs/interfaces/editorArguments.interface").EditorArguments) => void' is not assignable to type '(args?: import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editorArguments.interface").EditorArguments) => void'.
Types of parameters 'args' and 'args' are incompatible.
Type 'import("angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/editorArguments.interface").EditorArguments' is not assignable to type 'import("@slickgrid-universal/common/dist/commonjs/interfaces/editorArguments.interface").EditorArguments'.
The types of 'column.asyncPostRender' are incompatible between these types.
Type '(domCellNode: any, row: number, dataContext: any, columnDef: import("@slickgrid-universal/common/dist/commonjs/interfaces/column.interface").Column) => void' is not assignable to type '(domCellNode: any, row: number, dataContext: any, columnDef: import("node_modules/@slickgrid-universal/common/dist/commonjs/interfaces/column.interface").Column) => void'.
Types of parameters 'columnDef' and 'columnDef' are incompatible.
Type 'import("@slickgrid-universal/common/dist/commonjs/interfaces/column.interface").Column' is not assignable to type 'import("@slickgrid-universal/common/dist/commonjs/interfaces/column.interface").Column'.
The types of 'cellMenu.onExtensionRegistered' are incompatible between these types.
Type '(plugin: import("node_modules/@slickgrid-universal/common/dist/commonjs/extensions/slickCellMenu").SlickCellMenu) => void' is not assignable to type '(plugin: import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/extensions/slickCellMenu").SlickCellMenu) => void'.
Types of parameters 'plugin' and 'plugin' are incompatible.
Type 'import("node_modules/angular-slickgrid/node_modules/@slickgrid-universal/common/dist/commonjs/extensions/slickCellMenu").SlickCellMenu' is not assignable to type 'import("node_modules/@slickgrid-universal/common/dist/commonjs/extensions/slickCellMenu").SlickCellMenu'.
Property 'extensionUtility' is protected but type 'SlickCellMenu' is not a class derived from 'SlickCellMenu'.

Reproduction

Upgrade the "@slickgrid-universal/common" to 1.3.3
and "@slickgrid-universal/excel-export" to 1.3.3
then "angular-slickgrid" to 4.2.3

Environment Info

Angular 14.0.5
Angular-Slickgrid 4.2.3
Typescript 4.7.4
Browsers NA
System Windows 10

Validations

@kiranbangar5946
Copy link

kiranbangar5946 commented Jul 7, 2022

Hi, @roopeshkurian would suggest to use dependencies of slickgrid universal from package.json of [https://github.com/ghiscoding/Angular-Slickgrid/releases/tag/v4.2.3] which was released in 4.2.3 angular-slickgrid version.Kindly refer to https://github.com/ghiscoding/Angular-Slickgrid/issues/951. Just a suggestion if it works.Thanks.

@ghiscoding
Copy link
Owner

The suggestion is correct, whenever a new version of Angular-Slickgrid is out (I made another one yesterday), you must update all Slickgrid-Universal dependencies as well because if you don't then you will have similar issues to what you are currently having. I also jus tried the demo and the Excel Export works as expected, so there's no issue

ghiscoding added a commit that referenced this issue Jul 7, 2022
fix(build): version of Slickgrid-Universal are out of sync, fixes #956
@ghiscoding
Copy link
Owner

ah sorry I pushed a new version of Slickgrid-Universal without releasing a new version here and that caused an out of sync between the versions and the interfaces. I pushed a fix, please make sure to update both Angular-Slickgrid (to 4.2.4) and Slickgrid-Universal (to 1.3.3). The Angular-Slickgrid-Demos were all updated as well. Thanks for the feedback

@roopeshkurian
Copy link
Author

Thank you for your help once again. I downloaded 4.2.4 version. And everything works great. Thank you for your quick response and fix.

@roopeshkurian
Copy link
Author

Hi, @roopeshkurian would suggest to use dependencies of slickgrid universal from package.json of [https://github.com/ghiscoding/Angular-Slickgrid/releases/tag/v4.2.3] which was released in 4.2.3 angular-slickgrid version.Kindly refer to https://github.com/ghiscoding/Angular-Slickgrid/issues/951. Just a suggestion if it works.Thanks.

Thank you so much for your suggestion. I downloaded 4.2.4 . Now everything is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants