Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spreading 2 grids options causes duplicate ext resources #1126

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 15, 2023

  • partially rolls back PR fix: registered external resouces should keep singleton ref #1118 because that caused a regression that was identified by a user of Angular-Slickgrid in which defining a global external resource for ExcelExport no longer worked.
  • this PR also fixes duplicatation of external resources when having multiple grid on the same page and spreading grid options of another grid (e.g.: { ...this.gridOptions1, sortable: false })

image

- partially rolls back PR #1118 because that caused a regression that was identified by a user of Angular-Slickgrid in which defining a global external resource for ExcelExport no longer worked.
- this PR also fixes duplicatation of external resources when having multiple grid on the same page and spreading grid options of another grid (e.g.: `{ ...this.gridOptions1, sortable: false }`)
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (9ae758c) 22.74% compared to head (b4fcf69) 22.64%.

Files Patch % Lines
...lia-slickgrid/custom-elements/aurelia-slickgrid.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   22.74%   22.64%   -0.10%     
==========================================
  Files           8        8              
  Lines         893      897       +4     
  Branches      313      316       +3     
==========================================
  Hits          203      203              
- Misses        690      694       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 00a0be2 into master Dec 15, 2023
3 of 4 checks passed
@ghiscoding ghiscoding deleted the bugfix/duplicate-external-resources branch December 15, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant