Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: I18N could be optional when providing single locale #1129

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

ghiscoding
Copy link
Owner

when using a single locale, we should be able to skip the use of I18N altogether and not have to register it. This should fix the single locale demo that was not yet working

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2441e6) 22.72% compared to head (7ab7c6d) 22.72%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   22.72%   22.72%           
=======================================
  Files           8        8           
  Lines         898      898           
  Branches      316      319    +3     
=======================================
  Hits          204      204           
  Misses        694      694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 94fcfce into master Dec 19, 2023
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/optional-i18n branch December 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant