Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (re)add option to cancel Row Detail opening #1136

Merged
merged 5 commits into from
Dec 30, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 27, 2023

  • I tried to implement this feature in a previous PR but that introduced a regression which is got fixed in this PR and reintroduces this feature without regressing this time.

TODOs

  • requires new Slickgrid-Universal release

- I tried to implement this feature in a previous PR but that introduced a regression which is got fixed in this PR and reintroduces this feature without regressing this time.
@ghiscoding ghiscoding added the requires Universal change/release code change must first be implement in Slickgrid-Universal label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a467d14) 22.82% compared to head (be962b6) 22.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   22.82%   22.91%   +0.09%     
==========================================
  Files           8        8              
  Lines         894      895       +1     
  Branches      314      314              
==========================================
+ Hits          204      205       +1     
  Misses        690      690              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding marked this pull request as draft December 27, 2023 07:03
@ghiscoding ghiscoding marked this pull request as ready for review December 30, 2023 18:59
@ghiscoding ghiscoding merged commit b4980ec into master Dec 30, 2023
4 checks passed
@ghiscoding ghiscoding deleted the chore/cancellable-onbeforerowdetail branch December 30, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires Universal change/release code change must first be implement in Slickgrid-Universal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant