Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 1.9.x] - post release feedback #30

Closed
ghiscoding opened this issue Mar 13, 2018 · 2 comments
Closed

[release 1.9.x] - post release feedback #30

ghiscoding opened this issue Mar 13, 2018 · 2 comments

Comments

@ghiscoding
Copy link
Owner

@jmzagorski
Opening this simply for reference and discussions about latest version 1.9.0

  1. Jumped over 1.8.0, I'm so used to updating the package.json directly for the version that I forgot that isn't needed anymore, which explain the jump.
  2. Have you started using WebPack 4? I see the Aurelia-CLI got some commit around it
  3. I'm having some issues with the Build of Github Page, have you ever seen this problem? There's no double quotes on any of the scrips src or css href. That is causing some issues with the demo, until I change them all (by hand) to be wrapper in double quotes.
    1. I have tried to update a few of the Aurelia lib but that doesn't seem to do any changes
    2. could it be the webpack.config?

quotes

@ghiscoding ghiscoding changed the title [release 1.9.0] - post release [release 1.9.x] - post release Mar 13, 2018
@ghiscoding ghiscoding changed the title [release 1.9.x] - post release [release 1.9.x] - post release feedback Mar 13, 2018
@jmzagorski
Copy link
Collaborator

Have you started using WebPack 4? I see the Aurelia-CLI got some commit around it

I am still on "webpack": "^2.6.1", :-(. I realllly need to update, but I have been so involved with getting my application updated to version 2.0, updating webpack has been an afterthought.

I'm having some issues with the Build of Github Page, have you ever seen this problem?

I have never seen that before, probably because I am so behind on updating my builds. What file has those src and href without quotes?

@ghiscoding
Copy link
Owner Author

ghiscoding commented Mar 13, 2018

I don't know when I'll go to WebPack 4, the Aurelia CLI with WebPack 4 is not released yet so I'll wait until it does and possibly update some of our bundles.

The missing double quotes is annoying but not a big deal, perhaps that might be fixed after updating to WebPack 4, so I'll wait until that day happens. I was just curious if you ever saw that problem and you didn't.

Side note
I have now released Compound Filters (input & date so far) in my Angular repo, you can see a demo of it here, lovin' it hehe

Technically I could have added an extra one for Compound Multiselect Filter that would add Operators (IN and NIN (not in)) but I don't really need it for now, so that can wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants