Skip to content

Commit

Permalink
fix(core): properly export Enums, Interfaces, Services & Utilities (#184
Browse files Browse the repository at this point in the history
)
  • Loading branch information
ghiscoding committed Dec 1, 2020
1 parent 1225dc5 commit 0c23398
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
2 changes: 2 additions & 0 deletions packages/common/src/enums/enums.index.ts
@@ -0,0 +1,2 @@
import * as Enums from './index';
export { Enums };
13 changes: 6 additions & 7 deletions packages/common/src/index.ts
@@ -1,5 +1,9 @@
import 'multiple-select-modified';

import * as BackendUtilities from './services/backend-utilities';
import * as ServiceUtilities from './services/utilities';
import * as SortUtilities from './sortComparers/sortUtilities';

// Public classes.
export * from './constants';
export * from './global-grid-options';
Expand All @@ -22,14 +26,9 @@ export * from './grouping-formatters/index';
export * from './grouping-formatters/groupingFormatters.index';
export * from './sortComparers/index';
export * from './sortComparers/sortComparers.index';

import * as Enums from './enums/index';
import * as Interfaces from './interfaces/index';
import * as BackendUtilities from './services/backend-utilities';
import * as ServiceUtilities from './services/utilities';
import * as SortUtilities from './sortComparers/sortUtilities';
export * from './services/index';
export { Enums } from './enums/enums.index';

const Utilities = { ...BackendUtilities, ...ServiceUtilities, ...SortUtilities };
export { Enums, Interfaces };
export { Utilities };
export { SlickgridConfig } from './slickgrid-config';
8 changes: 1 addition & 7 deletions packages/vanilla-bundle/src/index.ts
Expand Up @@ -24,13 +24,7 @@ if (typeof window !== 'undefined') {

export { BindingService };
export { Aggregators, Editors, Enums, Filters, Formatters, GroupTotalFormatters, SortComparers, Utilities };
export { SlickCompositeEditorComponent, SlickEmptyWarningComponent, SlickVanillaGridBundle }; // export the custom components & interface
export { SlickCompositeEditorComponent, SlickEmptyWarningComponent, SlickVanillaGridBundle }; // export the custom components & interfaces
export { Slicker };
export * from './interfaces/index';
export * from './services/index';

// re-export all Enums & Interfaces into the Vanilla Grid Bundle, so that we can import any of the models from Package/common or Vanilla Bundle
// for example, we can import Column from the Common Package OR the Vanilla-bundle Package
// import { Column } from '@slickgrid-universal/common'; OR import { Column } from '@slickgrid-universal/vanilla-bundle';
export * from '@slickgrid-universal/common/dist/commonjs/enums/index';
export * from '@slickgrid-universal/common/dist/commonjs/interfaces/index';
1 change: 1 addition & 0 deletions test/cypress.json
@@ -1,6 +1,7 @@
{
"baseUrl": "http://localhost:8888",
"baseExampleUrl": "http://localhost:8888/#",
"runMode": 2,
"video": false,
"viewportWidth": 1000,
"viewportHeight": 950,
Expand Down

0 comments on commit 0c23398

Please sign in to comment.