Skip to content

Commit

Permalink
feat(styling)!: remove SASS math.div polyfill (#1483)
Browse files Browse the repository at this point in the history
- this might mean that old UI framework like Bootstrap v4 will not work. So I'm tagging this as a breaking change for the next major
- it removes a polyfill that was used in place of SASS `math.div` that should be use for division (instead of `/` character)
  • Loading branch information
ghiscoding committed Apr 27, 2024
1 parent 70cda8a commit 12661a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 31 deletions.
27 changes: 0 additions & 27 deletions packages/common/src/styles/_private.scss

This file was deleted.

8 changes: 4 additions & 4 deletions packages/common/src/styles/slick.layout.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
@use './private';
@use 'sass:math';

/* Medium devices (landscape tablets, 768px and up) */
@media only screen and (min-width : 768px) {
@for $i from 1 through 12 {
$width: private.private-div($i, 12) * 100%;
$width: math.div($i, 12) * 100%;
.slick-col-medium-#{$i} {
flex-basis: $width;
}
Expand All @@ -13,7 +13,7 @@
/* Large devices (laptops/desktops, 992px and up) */
@media only screen and (min-width : 992px) {
@for $i from 1 through 12 {
$width: private.private-div($i, 12) * 100%;
$width: math.div($i, 12) * 100%;
.slick-col-large-#{$i} {
flex-basis: $width;
}
Expand All @@ -23,7 +23,7 @@
/* Extra large devices (large laptops and desktops, 1200px and up) */
@media only screen and (min-width: 1200px) {
@for $i from 1 through 12 {
$width: private.private-div($i, 12) * 100%;
$width: math.div($i, 12) * 100%;
.slick-col-xlarge-#{$i} {
flex-basis: $width;
}
Expand Down

0 comments on commit 12661a3

Please sign in to comment.