fix(core): deleting Slicker object caused issue with cache

- previous PR #606 to avoid mem leaks actually create an unintended issue, with Salesforce at least, caching broke because Slicker was no longer exist but the cache think it does.
ghiscoding · Feb 8, 2022 · 3f3e261 · 3f3e261
1 parent bcb11cd
commit 3f3e261
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 1 deletion.
diff --git a/packages/vanilla-bundle/src/components/slick-vanilla-grid-bundle.ts b/packages/vanilla-bundle/src/components/slick-vanilla-grid-bundle.ts
@@ -465,7 +465,6 @@ export class SlickVanillaGridBundle {
     }
     this._eventPubSubService?.dispose();
     this._slickerGridInstances = null as any;
-    delete (window as any).Slicker;
   }
 
   initialization(gridContainerElm: HTMLElement, eventHandler: SlickEventHandler) {

diff --git a/packages/vanilla-force-bundle/dist-grid-bundle-zip/slickgrid-vanilla-bundle.zip b/packages/vanilla-force-bundle/dist-grid-bundle-zip/slickgrid-vanilla-bundle.zip