fix: try adding sort icon on non sortable column shouldn't throw

ghiscoding · Nov 24, 2023 · 4791fc8 · 4791fc8
1 parent 1be1d72
commit 4791fc8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/common/src/core/slickGrid.ts b/packages/common/src/core/slickGrid.ts
@@ -2819,12 +2819,14 @@ export class SlickGrid<TData = any, C extends Column<TData> = Column<TData>, O e
         const column = this.getColumnByIndex(columnIndex);
         if (column) {
           column.classList.add('slick-header-column-sorted');
-          let indicator = column.querySelector('.slick-sort-indicator') as HTMLElement;
-          indicator.classList.add(col.sortAsc ? 'slick-sort-indicator-asc' : 'slick-sort-indicator-desc');
+          let indicator = column.querySelector('.slick-sort-indicator');
+          indicator?.classList.add(col.sortAsc ? 'slick-sort-indicator-asc' : 'slick-sort-indicator-desc');
 
           if (numberCols) {
             indicator = column.querySelector('.slick-sort-indicator-numbered') as HTMLElement;
-            indicator.textContent = String(i);
+            if (indicator) {
+              indicator.textContent = String(i);
+            }
           }
         }
       }