fix(plugin): Grid Menu Clear Frozen Cols shouldn't change cols positi…

…ons (#291)
ghiscoding · Mar 18, 2021 · 4fdab08 · 4fdab08
1 parent 2a91fa6
commit 4fdab08
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/common/src/extensions/gridMenuExtension.ts b/packages/common/src/extensions/gridMenuExtension.ts
@@ -397,7 +397,10 @@ export class GridMenuExtension implements Extension {
         case 'clear-frozen-columns':
           const visibleColumns = [...this.sharedService.visibleColumns];
           this.sharedService.slickGrid.setOptions({ frozenColumn: -1, enableMouseWheelScrollHandler: false });
-          if (Array.isArray(visibleColumns) && Array.isArray(this.sharedService.allColumns) && visibleColumns.length !== this.sharedService.allColumns.length) {
+
+          // SlickGrid seems to be somehow resetting the columns to their original positions,
+          // so let's re-fix them to the position we kept as reference
+          if (Array.isArray(visibleColumns)) {
             this.sharedService.slickGrid.setColumns(visibleColumns);
           }
           break;

diff --git a/packages/vanilla-bundle/dist-grid-bundle-zip/slickgrid-vanilla-bundle.zip b/packages/vanilla-bundle/dist-grid-bundle-zip/slickgrid-vanilla-bundle.zip