Skip to content

Commit

Permalink
fix(common): switch to autocompleter-es to get ESM build (#1449)
Browse files Browse the repository at this point in the history
- migrate to a temp package `autocompleter-es` until my opened PR on `autocompleter` is merged and hopefully release sometime in the future.
- the goal of this switch is to have an ESM build so that we can remove it from `allowedCommonJsDependencies` (`angular.json`) for Angular-Slickgrid to have 1 less CJS dependency
  • Loading branch information
ghiscoding committed Mar 31, 2024
1 parent 75d1bde commit aa59334
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@slickgrid-universal/utils": "workspace:~",
"@types/dompurify": "^3.0.5",
"@types/sortablejs": "^1.15.8",
"autocompleter": "^9.1.2",
"autocompleter-es": "^9.1.4",
"dequal": "^2.0.3",
"excel-builder-vanilla": "3.0.1",
"flatpickr": "^4.6.13",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { AutocompleteItem } from 'autocompleter';
import type { AutocompleteItem } from 'autocompleter-es';

import type { AutocompleterOption } from '../interfaces/index';

Expand Down
4 changes: 2 additions & 2 deletions packages/common/src/editors/autocompleterEditor.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import autocompleter from 'autocompleter';
import type { AutocompleteItem, AutocompleteResult, AutocompleteSettings } from 'autocompleter';
import autocompleter from 'autocompleter-es';
import type { AutocompleteItem, AutocompleteResult, AutocompleteSettings } from 'autocompleter-es';
import { BindingEventService } from '@slickgrid-universal/binding';
import { classNameToList, createDomElement, isObject, isPrimitiveValue, setDeepValue, toKebabCase } from '@slickgrid-universal/utils';

Expand Down
4 changes: 2 additions & 2 deletions packages/common/src/filters/autocompleterFilter.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import autocompleter from 'autocompleter';
import type { AutocompleteItem, AutocompleteSettings } from 'autocompleter';
import autocompleter from 'autocompleter-es';
import type { AutocompleteItem, AutocompleteSettings } from 'autocompleter-es';
import { BindingEventService } from '@slickgrid-universal/binding';
import { classNameToList, createDomElement, emptyElement, isPrimitiveValue, toKebabCase, toSentenceCase } from '@slickgrid-universal/utils';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { AutocompleteItem, AutocompleteSettings } from 'autocompleter';
import type { AutocompleteItem, AutocompleteSettings } from 'autocompleter-es';
import type { Column } from './column.interface';

export interface AutoCompleterRenderItemDefinition {
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit aa59334

Please sign in to comment.