fix(editors): make sure editor element exist before focusing

ghiscoding · Nov 25, 2020 · e57235b · e57235b
1 parent 3c05938
commit e57235b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/packages/common/src/editors/autoCompleteEditor.ts b/packages/common/src/editors/autoCompleteEditor.ts
@@ -198,7 +198,9 @@ export class AutoCompleteEditor implements Editor {
   }
 
   focus() {
-    this._$editorElm?.focus().select();
+    if (this._$editorElm) {
+      this._$editorElm.focus().select();
+    }
   }
 
   show() {

diff --git a/packages/common/src/editors/dateEditor.ts b/packages/common/src/editors/dateEditor.ts
@@ -216,7 +216,9 @@ export class DateEditor implements Editor {
   }
 
   focus() {
-    this._$input.focus();
+    if (this._$input) {
+      this._$input.focus();
+    }
     if (this._$inputWithData && typeof this._$inputWithData.focus === 'function') {
       this._$inputWithData.focus().select();
     }

diff --git a/packages/common/src/editors/longTextEditor.ts b/packages/common/src/editors/longTextEditor.ts
@@ -198,7 +198,9 @@ export class LongTextEditor implements Editor {
   }
 
   focus() {
-    this._$textarea.focus().select();
+    if (this._$textarea) {
+      this._$textarea.focus().select();
+    }
   }
 
   getValue(): string {

diff --git a/packages/common/src/editors/sliderEditor.ts b/packages/common/src/editors/sliderEditor.ts
@@ -152,7 +152,9 @@ export class SliderEditor implements Editor {
   }
 
   focus() {
-    this._$input.focus();
+    if (this._$input) {
+      this._$input.focus();
+    }
   }
 
   show() {