Skip to content

Commit

Permalink
feat(filters)!: remove native Filters.select (#1485)
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiscoding committed Apr 27, 2024
1 parent 2de3fe2 commit fae4c4a
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 667 deletions.
17 changes: 17 additions & 0 deletions docs/migrations/migration-to-5.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,23 @@ const myCheckmarkFormatter: Formatter = (row: number, cell: number, value: any,
```

## Grid Functionalities

### Native Select Filter (removed)
I would be surprised if anyone uses the `Filters.select` and so it was removed, you should simply use the `Filters.singleSelect` or `Filters.multipleSelect`

```diff
prepareGrid() {
this.columnDefinitions = [{
id: 'isActive', name: 'Active', field: 'isActive',
filter: {
- model: Filters.select,
+ model: Filters.singleSelect,
collection: [ { value: '', label: '' }, { value: true, label: 'true' }, { value: false, label: 'false' } ],
}
}];
}
```

### Date Editor/Filter
We migrated from Flatpicker to Vanilla-Calendar and this require some changes since the option names are different. The changes are the same for both the Filter and the Editor.

Expand Down
Loading

0 comments on commit fae4c4a

Please sign in to comment.