Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): switch to autocompleter-es to get ESM build #1449

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

ghiscoding
Copy link
Owner

  • migrate to a temp package autocompleter-es until my opened PR on autocompleter is merged and hopefully release sometime in the future.
  • the goal of this switch is to have an ESM build so that we can remove it from allowedCommonJsDependencies (angular.json) for Angular-Slickgrid to have 1 less CJS dependency

- migrate to a temp package `autocompleter-es` until my opened PR on `autocompleter` is merged and hopefully release sometime in the future.
- the goal of this switch is to have an ESM build so that we can remove it from `allowedCommonJsDependencies` (`angular.json`) for Angular-Slickgrid to have 1 less CJS dependency
Copy link

stackblitz bot commented Mar 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (75d1bde) to head (4e40b88).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1449   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         199     199           
  Lines       21682   21682           
  Branches     7260    7260           
======================================
  Hits        21618   21618           
+ Misses         64      58    -6     
- Partials        0       6    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit aa59334 into master Mar 31, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/autocompleter-es branch March 31, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant