Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling)!: remove SASS math.div polyfill #1483

Merged
merged 2 commits into from Apr 27, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 27, 2024

  • this might mean that old UI framework like Bootstrap v4 will not work. So I'm tagging this as a breaking change for the next major
  • it removes a polyfill that was used in place of SASS math.div that should be use for division (instead of / character)

- this might mean that old UI framework like Bootstrap v4 will not work. So I'm tagging this as a breaking change for the next major
Copy link

stackblitz bot commented Apr 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the base branch from master to next April 27, 2024 00:31
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (70cda8a) to head (b01d8c8).

Additional details and impacted files
@@          Coverage Diff           @@
##            next   #1483    +/-   ##
======================================
  Coverage   99.8%   99.8%            
======================================
  Files        199     199            
  Lines      21763   21763            
  Branches    7264    6994   -270     
======================================
  Hits       21699   21699            
  Misses        64      64            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 12661a3 into next Apr 27, 2024
7 checks passed
@ghiscoding ghiscoding deleted the chore/remove-sass-polyfill branch April 27, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants