Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): empty warning should separate icon & text #1491

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ghiscoding
Copy link
Owner

  • the previous code was using the :before pseudo and we were able to add text to the same div but that is no longer feasible with the new pure CSS icons since the div is the icon and nothing else, so the text has to be in a separate div
  • also use flex to align the text and icon in the middle

- the previous code was using the `:before` pseudo and we were able to add text to the same div but that is no longer feasible with the new pure CSS icons since the div is the icon and nothing else, so the text has to be in a separate div
- also use flex to align the text and icon in the middle
Copy link

stackblitz bot commented Apr 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (69f7bfc) to head (9d3c664).

Additional details and impacted files
@@          Coverage Diff           @@
##            next   #1491    +/-   ##
======================================
  Coverage   99.7%   99.7%            
======================================
  Files        197     197            
  Lines      21652   21652            
  Branches    6938    7207   +269     
======================================
  Hits       21586   21586            
+ Misses        66      60     -6     
- Partials       0       6     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 240cbd3 into next Apr 29, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/empty-warning-separate branch April 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants