Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memory): clear & dispose of grid to avoid mem leaks & detached elm #606

Merged
merged 2 commits into from Jan 17, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 17, 2022

  • note that Flatpickr still has some mem/event leaks but a fix was put in place, we are just waiting for a new version release from their side to fix that leak
  • also fixed some leaks in my own custom rendered SPA, technically that shouldn't be a problem in a regular SPA framework

- note that Flatpickr still has some mem/event leaks but a fix was put in place, we are just waiting for a new version release from their side to fix that leak
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #606 (6abed20) into master (5863115) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #606   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          230       230           
  Lines        16068     16126   +58     
  Branches      5179      5195   +16     
=========================================
+ Hits         16068     16126   +58     
Impacted Files Coverage Δ
packages/common/src/extensions/menuBaseClass.ts 100.00% <100.00%> (ø)
...es/common/src/extensions/slickDraggableGrouping.ts 100.00% <100.00%> (ø)
packages/common/src/filters/compoundDateFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/dateRangeFilter.ts 100.00% <100.00%> (ø)
...ckages/common/src/services/bindingEvent.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/extension.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
...te-editor-component/src/compositeEditor.factory.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)
...tom-footer-component/src/slick-footer.component.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5863115...6abed20. Read the comment docs.

@ghiscoding ghiscoding merged commit cff4a8d into master Jan 17, 2022
@ghiscoding ghiscoding deleted the bugfix/mem-leaks branch January 17, 2022 20:59
ghiscoding-SE pushed a commit that referenced this pull request Feb 8, 2022
- previous PR #606 to avoid mem leaks actually create an unintended issue, with Salesforce at least, caching broke because Slicker was no longer exist but the cache think it does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant